Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Pass local python version explicitly to pre-commit mypy.sh #12224

Merged
merged 3 commits into from
Jan 20, 2025
Merged

[CI] Pass local python version explicitly to pre-commit mypy.sh #12224

merged 3 commits into from
Jan 20, 2025

Conversation

heheda12345
Copy link
Collaborator

@heheda12345 heheda12345 commented Jan 20, 2025 •
edited by github-actions bot
Loading

pre-commit passes all modified fills to mypy.sh, and $1 $2 will be filled by the path to modified filenames and I get the following errors:

tools/mypy.sh: line 12: [: vllm/v1/attention/backends/flash_attn.py: integer expression expected
usage: mypy [-h] [-v] [-V] [more options; see below]
            [-m MODULE] [-p PACKAGE] [-c PROGRAM_TEXT] [files ...]
mypy: error: argument --python-version: Invalid python version 'vllm/v1/worker/gpu_model_runner.py' (expected format: 'x.y')

This pr fixes the error by passing "local" explicitly.

@heheda12345
fix_pre_commit
c885a40 
Signed-off-by: Chen Zhang <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 reviewed Jan 20, 2025
View reviewed changes
.pre-commit-config.yaml Outdated
@@ -42,7 +42,7 @@ repos:
hooks:
- id: mypy-local
name: Run mypy for local Python installation
entry: tools/mypy.sh
entry: tools/mypy.sh 1 "local"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
entry: tools/mypy.sh 1 "local"
entry: tools/mypy.sh 0 "local"

Should be 0 here to indicate not running in CI

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. But why does here use CI=1?

name: Run mypy for Python 3.9
entry: tools/mypy.sh 1 "3.9"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version-locked steps are intended to be run in CI only.

@heheda12345
fix ci=0
6cb9dab 
Signed-off-by: Chen Zhang <[email protected]>
@heheda12345
fix local by default
9cf86e8 
Signed-off-by: Chen Zhang <[email protected]>
DarkLight1337
DarkLight1337 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@youkaichao youkaichao merged commit 9666369 into vllm-project:main Jan 20, 2025
6 of 9 checks passed
@kzawora-intel kzawora-intel mentioned this pull request Jan 21, 2025
Open
mhendrey pushed a commit to mhendrey/vllm that referenced this pull request Jan 23, 2025
@heheda12345 @mhendrey
[CI] Pass local python version explicitly to pre-commit mypy.sh (vllm…
b1af379 
…-project#12224)

Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Matthew Hendrey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heheda12345 @DarkLight1337 @youkaichao